[FEA] Enable UMAP to build knn graph using NN Descent #5910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh the check is failing because we need the updated implementation of RAFT NN Descent (linked above)...! |
viclafargue
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Great work! Just have a few suggestions. Also, it could be great to add this feature to the simplicial set functions. But, we could do that in another PR too.
divyegala
reviewed
Jul 26, 2024
|
Added warning and linked issue for consistency with previous version |
dantegd
added
feature request
|
/ok to test |
divyegala
approved these changes
Jul 30, 2024
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
build_algo=nn_descentoption to UMAP.Now user can choose the knn graph build algorithm between
"brute_force_knn"and"nn_descent"Defaults to
"auto", in which case decides to run with brute force knn or nn descent depending on the given dataset size."auto"decides to run withbrute_force_knnif either 1) data has <= 50K rows OR 2) data is sparse. Otherwise decides to run withnn_descent.50K rows roughly chosen based on grid search below. (runtime in ms) - Discussed with Corey
data_on_hostoption (defaults to False) when callingfit()orfit_transform()Note that brute force knn cannot be used with data on host
Running Benchmarks